refactor(transport): explicitly specify UTF-8 charset when creating InputStreamReader#717
Open
codeboyzhou wants to merge 5 commits intomodelcontextprotocol:mainfrom
Open
refactor(transport): explicitly specify UTF-8 charset when creating InputStreamReader#717codeboyzhou wants to merge 5 commits intomodelcontextprotocol:mainfrom
codeboyzhou wants to merge 5 commits intomodelcontextprotocol:mainfrom
Conversation
…readers Make scheduler fields final in client and server transports for better immutability. Explicitly specify UTF-8 charset when creating InputStreamReader instances to ensure consistent character encoding.
Member
|
Hi, thanks for the proposed change. Can you please look at #826 and also propose a test that validates the changes work as expected? |
Add test cases to verify proper UTF-8 character handling in StdioClientTransport when system default charset is not UTF-8. Includes a test echo server subprocess to simulate non-UTF-8 environment.
Contributor
Author
Ok, I have already supplemented and run the tests, the changes work as expected. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explicitly specify UTF-8 charset when creating
InputStreamReaderinstances.Motivation and Context
(SpotBugs check) Ensure consistent character encoding to avoid potential problem.
How Has This Been Tested?
Just run
./mvnw testBreaking Changes
Not involved
Types of changes
Checklist
Additional context
Not involved